push ex4 and ex5

code/Exercise4/src/main/java/fr/istic/vv/GetterChecker.java

@@ -4,7 +4,14 @@ import com.github.javaparser.ast.CompilationUnit;
 import com.github.javaparser.ast.body.*;
 import com.github.javaparser.ast.visitor.VoidVisitorWithDefaults;
 
+import java.io.PrintWriter;
+
 public class GetterChecker extends VoidVisitorWithDefaults<Void> {
+    private final PrintWriter out;
+    public GetterChecker(PrintWriter out) {
+        this.out = out;
+    }
+
     @Override
     public void visit(CompilationUnit unit, Void arg) {
         for(TypeDeclaration<?> type : unit.getTypes()) {
@@ -16,13 +23,14 @@ public class GetterChecker extends VoidVisitorWithDefaults<Void> {
     public void visit(final ClassOrInterfaceDeclaration n, final Void arg) {
         if (!n.isPublic())
             return;
-        System.out.println(n.getNameAsString());
+
+        out.println(n.getNameAsString());
         for (FieldDeclaration field : n.getFields()) {
             if (!field.isPrivate()) continue;
             for (VariableDeclarator variable : field.getVariables()) {
                 boolean hasGetter = false;
                 String fieldName = variable.getNameAsString();
-                System.out.println("---------------"+fieldName+"---------------");
+                out.println("---------------"+fieldName+"---------------");
                 String getterName1 = "get" + Character.toUpperCase(fieldName.charAt(0)) + fieldName.substring(1);
 
                 for (MethodDeclaration method : n.getMethods()) {
@@ -32,10 +40,10 @@ public class GetterChecker extends VoidVisitorWithDefaults<Void> {
                     }
                 }
                 if (!hasGetter) {
-                    System.out.println("  Missing getter for field: " + fieldName);
+                    out.println("  Missing getter for field: " + fieldName);
                 }
             }
         }
-        super.visit(n, arg);
+        out.println(" ");
     }
 }

code/Exercise4/src/main/java/fr/istic/vv/Main.java

@@ -10,6 +10,7 @@ import com.github.javaparser.utils.SourceRoot;
 
 import java.io.File;
 import java.io.IOException;
+import java.io.PrintWriter;
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
@@ -28,10 +29,13 @@ public class Main {
         }
 
         SourceRoot root = new SourceRoot(file.toPath());
-        GetterChecker checker = new GetterChecker();
-        root.parse("", (localPath, absolutePath, result) -> {
-            result.ifSuccessful(unit -> unit.accept(checker, null));
-            return SourceRoot.Callback.Result.DONT_SAVE;
-        });
+
+        try (PrintWriter writer = new PrintWriter("result_exercise4.txt")) {
+            GetterChecker checker = new GetterChecker(writer);
+            root.parse("", (localPath, absolutePath, result) -> {
+                result.ifSuccessful(unit -> unit.accept(checker, null));
+                return SourceRoot.Callback.Result.DONT_SAVE;
+            });
+        }
     }
 }

code/Exercise5/pom.xml

@@ -63,6 +63,14 @@
                     </execution>
                 </executions>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <configuration>
+                    <source>21</source>
+                    <target>21</target>
+                </configuration>
+            </plugin>
         </plugins>
     </build>
 

code/Exercise5/src/main/java/fr/istic/vv/CyclomaticComplexity.java

@@ -0,0 +1,43 @@
+package fr.istic.vv;
+
+
+import com.github.javaparser.ast.Node;
+import com.github.javaparser.ast.body.MethodDeclaration;
+import com.github.javaparser.ast.expr.ConditionalExpr;
+import com.github.javaparser.ast.stmt.*;
+import com.github.javaparser.ast.visitor.VoidVisitorAdapter;
+
+import java.io.PrintWriter;
+
+
+public class CyclomaticComplexity extends VoidVisitorAdapter<Void> {
+    private PrintWriter out;
+
+    public CyclomaticComplexity(PrintWriter out) {
+        this.out = out;
+    }
+
+    @Override
+    public void visit(MethodDeclaration method, Void arg) {
+        System.out.println("Found method: " + method.getDeclarationAsString());
+        int cc = 1;
+        for (Node node : method.findAll(Node.class)) {
+            if (node instanceof IfStmt
+                    || node instanceof ForStmt
+                    || node instanceof WhileStmt
+                    || node instanceof DoStmt
+                    || node instanceof CatchClause
+                    || node instanceof ConditionalExpr) {
+                cc++;
+            } else if (node instanceof SwitchEntry) {
+                SwitchEntry se = (SwitchEntry) node;
+                if (!(se.getLabels().isEmpty())) {
+                    cc++;
+                }
+            }
+        }
+        String resultLine = method.getNameAsString()+ ": " + cc;
+        out.println(resultLine);
+        out.flush();
+    }
+}

code/Exercise5/src/main/java/fr/istic/vv/Main.java

@@ -1,20 +1,13 @@
 package fr.istic.vv;
 
-import com.github.javaparser.Problem;
-import com.github.javaparser.ast.CompilationUnit;
-import com.github.javaparser.ast.body.ClassOrInterfaceDeclaration;
-import com.github.javaparser.ast.body.MethodDeclaration;
-import com.github.javaparser.ast.visitor.VoidVisitor;
-import com.github.javaparser.ast.visitor.VoidVisitorAdapter;
+
 import com.github.javaparser.utils.SourceRoot;
 
 import java.io.File;
 import java.io.IOException;
-import java.nio.file.Path;
-import java.nio.file.Paths;
+import java.io.PrintWriter;
 
 public class Main {
-
     public static void main(String[] args) throws IOException {
         if(args.length == 0) {
             System.err.println("Should provide the path to the source code");
@@ -28,12 +21,12 @@ public class Main {
         }
 
         SourceRoot root = new SourceRoot(file.toPath());
-        PublicElementsPrinter printer = new PublicElementsPrinter();
-        root.parse("", (localPath, absolutePath, result) -> {
-            result.ifSuccessful(unit -> unit.accept(printer, null));
-            return SourceRoot.Callback.Result.DONT_SAVE;
-        });
+        try (PrintWriter writer = new PrintWriter("result_exercise5.txt")) {
+            CyclomaticComplexity checker = new CyclomaticComplexity(writer);
+            root.parse("", (localPath, absolutePath, result) -> {
+                result.ifSuccessful(unit -> unit.accept(checker, null));
+                return SourceRoot.Callback.Result.DONT_SAVE;
+            });
+        }
     }
-
-
 }

code/Exercise5/src/main/java/fr/istic/vv/PublicElementsPrinter.java

@@ -1,48 +0,0 @@
-package fr.istic.vv;
-
-import com.github.javaparser.ast.CompilationUnit;
-import com.github.javaparser.ast.body.*;
-import com.github.javaparser.ast.visitor.VoidVisitorWithDefaults;
-
-
-// This class visits a compilation unit and
-// prints all public enum, classes or interfaces along with their public methods
-public class PublicElementsPrinter extends VoidVisitorWithDefaults<Void> {
-
-    @Override
-    public void visit(CompilationUnit unit, Void arg) {
-        for(TypeDeclaration<?> type : unit.getTypes()) {
-            type.accept(this, null);
-        }
-    }
-
-    public void visitTypeDeclaration(TypeDeclaration<?> declaration, Void arg) {
-        if(!declaration.isPublic()) return;
-        System.out.println(declaration.getFullyQualifiedName().orElse("[Anonymous]"));
-        for(MethodDeclaration method : declaration.getMethods()) {
-            method.accept(this, arg);
-        }
-        // Printing nested types in the top level
-        for(BodyDeclaration<?> member : declaration.getMembers()) {
-            if (member instanceof TypeDeclaration)
-                member.accept(this, arg);
-        }
-    }
-
-    @Override
-    public void visit(ClassOrInterfaceDeclaration declaration, Void arg) {
-        visitTypeDeclaration(declaration, arg);
-    }
-
-    @Override
-    public void visit(EnumDeclaration declaration, Void arg) {
-        visitTypeDeclaration(declaration, arg);
-    }
-
-    @Override
-    public void visit(MethodDeclaration declaration, Void arg) {
-        if(!declaration.isPublic()) return;
-        System.out.println("  " + declaration.getDeclarationAsString(true, true));
-    }
-
-}

exercises/using-pmd.md

@@ -4,11 +4,13 @@ Pick a Java project from Github (see the [instructions](../sujet.md) for suggest
 
 ## Answer
 
-We clone the project `commons-math`
+Nous avons cloné le projet `commons-math`
 https://github.com/apache/commons-math
-We found a problem that it's not worth to change 
+
+On a trouvé un problème qu’il ne vaut pas la peine de changer :
 `./commons-math/commons-math-core/src/main/java/org/apache/commons/math4/core/jdkmath/AccurateMath.java:396:	UselessParentheses:	Useless parentheses around `0.5 * t`.`
-And here is the code that PMD a indiqué: 
+
+Et voici le code que PMD a indiqué:
 ```
             if (x >= LOG_MAX_VALUE) {
                 // Avoid overflow (MATH-905).
@@ -16,9 +18,9 @@ And here is the code that PMD a indiqué:
                 return (0.5 * t) * t;
 ```
 
-As we can see the parentheses didn't cause any harm here but it is a true positive
+Comme on peut le voir, les parenthèses ne causent aucun problème ici, mais c’est un vrai positif.
 
-For a false positive, we found this one: 
+Pour un faux positif, nous avons trouvé celui-ci:
 `./commons-math/commons-math-legacy-core/src/test/java/org/apache/commons/math4/legacy/core/IntegerSequenceTest.java:255:	UnusedLocalVariable:	Avoid unused local variables such as 'inc'.`
 
 ```
@@ -33,4 +35,6 @@ For a false positive, we found this one:
 
 ```
 
-Because the purpose of the test is to trigger the bug when create object.
+
+
+Parce que le but du test est de déclencher le bug lors de la création de l’objet.