Modified HTTP status on create when user already exists

Changed from 409 CONFLICT to 302 FOUND
This commit is contained in:
Alexis Leboeuf
2026-01-09 08:40:40 +01:00
parent dc814d4a7b
commit 3eadabfa4c
2 changed files with 5 additions and 3 deletions

View File

@@ -9,7 +9,6 @@ import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.security.access.prepost.PreAuthorize;
import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.CrossOrigin;
import org.springframework.web.bind.annotation.DeleteMapping;
import org.springframework.web.bind.annotation.GetMapping;
@@ -52,7 +51,7 @@ public class AthleteResource {
public ResponseEntity<AthleteDTO> create(@RequestBody AthleteDTO dto) {
Athlete athlete = mapToEntity(dto);
if(athleteDAO.existsByKeycloakId(athlete.getKeycloakId())) {
return ResponseEntity.status(HttpStatus.CONFLICT).body(mapToDTO(athleteDAO.findByKeycloakId(athlete.getKeycloakId()).get()));
return ResponseEntity.status(HttpStatus.FOUND).body(mapToDTO(athleteDAO.findByKeycloakId(athlete.getKeycloakId()).get()));
}
athleteDAO.save(athlete);
return ResponseEntity.status(HttpStatus.CREATED).body(mapToDTO(athlete));
@@ -164,6 +163,7 @@ public class AthleteResource {
@ApiResponse(responseCode = "200", description = "Récupération effectuée", content = @Content(mediaType = "application/json", schema = @Schema(implementation = SessionDTO.class)))
})
@GetMapping("/athlete/{id}/session")
@PreAuthorize("hasRole('admin') or #id == principal.id")
public List<SessionDTO> getSessionsAthlete(@PathVariable Integer athleteId) {
// return pet
System.out.println("ID A CHERCHER" + athleteId);
@@ -282,4 +282,6 @@ public class AthleteResource {
}
return new ArrayList<>();
}
}

View File

@@ -25,7 +25,7 @@ public class CoachResource {
public ResponseEntity<CoachDTO> create(@RequestBody CoachDTO dto) {
Coach coach = mapToEntity(dto);
if(coachDAO.existsByKeycloakId(coach.getKeycloakId())) {
return ResponseEntity.status(HttpStatus.CONFLICT).body(mapToDTO(coachDAO.findByKeycloakId(coach.getKeycloakId()).get()));
return ResponseEntity.status(HttpStatus.FOUND).body(mapToDTO(coachDAO.findByKeycloakId(coach.getKeycloakId()).get()));
}
coachDAO.save(coach);
return ResponseEntity.status(HttpStatus.CREATED).body(mapToDTO(coach));